🌱 Regenerate CRD Integration Test testdata

[erikgb]

I am considering submitting a functional PR, and had a look in the codebase - to get a bit familiar. Since I am probably going to suggest a new CRD marker, I took special note on the process for generating testdata.

And it seems like the "golden output file" hasn't been re-generated lately. At least I get a big diff related to newlines in the desciption fields. Possibly related issue: #514.

[k8s-ci-robot]

Welcome @erikgb!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[erikgb]

@mengqiy @pwittrock Would it make sense to split this PR? One for generating the missing help message (🐛) and one for re-generating the test resources (🌱)? And do you require an issue for each PR?

[erikgb]

@mengqiy @pwittrock Would it make sense to split this PR? One for generating the missing help message (🐛) and one for re-generating the test resources (🌱)? And do you require an issue for each PR?

I think so, and created #597 for the bugfix.

[erikgb]

/assign @mengqiy

Any chance to have a review on this? It is "just" a re-generation of what appears to be outdated files - and no "real" changes - just YAML reformatting. This is kinda blocking any progress on my functional PR....

[camilamacedo86]

Hi @erikgb,

So, the testdata has not been checked if is updated for each PR?
If that is the case, IHMO the solution should be we start to check that in the CI as we do in Kubebuilder. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/testdata.yml

[erikgb]

@camilamacedo86 Thx for taking a look at this old PR!

So, the testdata has not been checked if is updated for each PR?

No, it seems like some PRs have been merged without update to the testdata.

If that is the case, IHMO the solution should be we start to check that in the CI as we do in Kubebuilder. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/testdata.yml

I totally agree! I will try to update this PR with a GHA-job that verifies that the generated code is up to date. Will ping you for a new review when that is done.

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment