Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨: deepcopy: gen: match Go 1.17 build tag format #595

Merged
merged 1 commit into from
May 6, 2022
Merged

✨: deepcopy: gen: match Go 1.17 build tag format #595

merged 1 commit into from
May 6, 2022

Conversation

benpbrown
Copy link
Contributor

The Go team has started the process of replacing the old "// +build"
constraints with the new "//go:build" constraints. See the design
doc for more details here:

https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

What is relevant is that in Go 1.17, gofmt now synchronizes the two
styles. In particular, if gofmt is run against a deepcopy generated
file, it will add a new "//go:build" constraint.

See https://golang.org/doc/go1.17#gofmt for details.

This PR intends to make it so that the generated code is compliant with
the new gofmt style.

Relevant issue: #594

The Go team has started the process of replacing the old "// +build"
constraints with the new "//go:build" constraints. See the design
doc for more details here:

https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

What is relevant is that in Go 1.17, gofmt now synchronizes the two
styles. In particular, if gofmt is run against a deepcopy generated
file, it will add a new "//go:build" constraint.

See https://golang.org/doc/go1.17#gofmt for details.

This PR intends to make it so that the generated code is compliant with
the new gofmt style.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @benpbrown!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2021
@benpbrown
Copy link
Contributor Author

I have signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2021
@benpbrown benpbrown changed the title deepcopy: gen: match Go 1.17 build tag format (✨) deepcopy: gen: match Go 1.17 build tag format (✨) ✨ Aug 17, 2021
@benpbrown benpbrown changed the title deepcopy: gen: match Go 1.17 build tag format (✨) ✨ ✨: deepcopy: gen: match Go 1.17 build tag format Aug 17, 2021
@benpbrown
Copy link
Contributor Author

Gentle ping for review @mengqiy @droot

@benpbrown
Copy link
Contributor Author

Gentle ping for for review from the reviewers group (@droot @mengqiy @pwittrock @vincepri)

@benpbrown
Copy link
Contributor Author

Ping for review @droot @mengqiy @pwittrock @vincepri

@benpbrown
Copy link
Contributor Author

/assign @mengqiy

@benpbrown
Copy link
Contributor Author

Ping for review @droot @mengqiy @pwittrock @vincepri

@camilamacedo86
Copy link
Member

IHMO we need to update first k8s then controller runtime and then we can do this update here. See: operator-framework/operator-sdk#5208 (comment)

@benpbrown
Copy link
Contributor Author

Hi @camilamacedo86 thanks for your message.

I understand that it would be desirable to upgrade the Go version used to compile Kubernetes (and related repos) all at once, but I don't quite follow the connection to this PR.

This PR doesn't use Go 1.17 for building controller-tools (it still uses 1.16). The change is in the codegen emitted by controller-tools, which becomes forwards compatible with 1.17.

Happily, the emitted code is backwards compatible with Go 1.16 (Go 1.16 added support for the new style build tags), so contributors will continue to use Go 1.16 on this repo.

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 13, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@benpbrown
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, benpbrown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@alvaroaleman
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link
Member

/reopen
(to trigger the CLA bot)

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: Reopened this PR.

In response to this:

/reopen
(to trigger the CLA bot)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit a260f13 into kubernetes-sigs:master May 6, 2022
thbkrkr added a commit to elastic/cloud-on-k8s that referenced this pull request May 25, 2022
Update all current build tags `// +build` to new format accepted in go 1.17 `//go:build`.
`zz_generated.deepcopy.go` files contains both tags because `controller-tools` does 
the migration smoothly (kubernetes-sigs/controller-tools#595).
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
Update all current build tags `// +build` to new format accepted in go 1.17 `//go:build`.
`zz_generated.deepcopy.go` files contains both tags because `controller-tools` does 
the migration smoothly (kubernetes-sigs/controller-tools#595).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants