🐛 Allow pattern usage for IntOrString fields

[JoelSpeed]

As of today, if you want to add a pattern to a CRD field, the field has to be a string or you have to specify that it is of type string. Patterns are also compatible with XIntOrString but the CRD generator won't allow you to do this.

When patterns are used with the IntOrString type, the validation is run if a string is detected, but not run when an integer is detected. I have a use case where I want to ensure that the field is either an integer or percentage, and a pattern can be useful for validating the percentage.

There is also a workaround today where you can manually set a IntOrString field to a string type, but then validation blows up when you put an integer in.

This PR should allow patterns when an IntOrString field is used.

[alvaroaleman]

/lgtm
/assign @vincepri

[vincepri]

Do we need to update the error message?

[JoelSpeed]

Can do, I wasn't sure originally though because I couldn't think of a good way to express the IntOrString, perhaps must apply pattern to a string or IntOrString but I don't like the inconsistency of casing 🤔

[vincepri]

That sounds like a good improvement over the current error message, maybe let's put backtick quotes around those types?

[JoelSpeed]

Have pushed an update with the new error message

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, JoelSpeed, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment