🐛 Allow floating-point values in validations

[Porges]

Closes #543. We have also run into this while working on https://github.com/Azure/azure-service-operator.

• Extend marker parser to allow parsing float/JSON number values.
• Allow validations for Minimum, Maximum, and MultipleOf to have float values when applied to float fields.

Actual use of float fields is still restricted by the allowDangerousTypes flag, so no further restrictions are needed as part of this change.

[k8s-ci-robot]

Hi @Porges. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[Porges]

/remove-lifecycle rotten

bad bot

[matthchr]

It would be nice to get this merged. It's been open for a while.

[erikgb]

Did a quick scan. Looks reasonable to me, but I am not too familiar with this codebase.

/ok-to-test

[AlmogBaku]

Hi, Thanks for your contribution!

Overall it looks good to me, I'm just wondering about this "AllowDangerousTypes" that you also added in the marker

[AlmogBaku]

/lgtm

[joelanford]

For some nits:
/hold

But its nothing to block merging over, so:
/approve

If you want to accept the nits, ping me again and I can re-add lgtm and approve labels.

[Porges]

@AlmogBaku Overall it looks good to me, I'm just wondering about this "AllowDangerousTypes" that you also added in the marker

It’s required in order to use float values at all in the test file.

[erikgb]

/lgtm

[joelanford]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlmogBaku, joelanford, Porges

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

/hold cancel

[Porges]

Thanks for reviewing @joelanford