-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Bump sigs.k8s.io/yaml v1.3.0 and call yaml.v2.FutureLineWrap #623
Conversation
…lines in yaml not being wrapped
Welcome @akram! |
Hi @akram. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @pwittrock |
/assign joelanford |
/ok-to-test |
@alvaroaleman any comments about it? do you think that it can be merged as is? |
@akram can you please link to something in the libs that confirms that this fixes the Linux/Mac discrepancy, mark the PR as breaking and describe what other behavior it will change? |
I don't see any mention about linux/mac discrepancies which is what this change claims to fix? |
@akram: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bump sigs.k8s.io/yaml to
v1.3.0
and callsyaml.v2.FutureLineWrap
to make lines in yaml not being wrappedWarning: This change may be a breaking change for many existing users. So I am asking a review for it and maybe discussion on if we should set the behaviour as default or not.
The goal is to fix #514