-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add support for kubernetes +required annotations #944
Conversation
/lgtm |
LGTM label has been added. Git tree hash: fcc1db5628bc614c8d0efd02ed32a6bccddf3a9c
|
One minor finding |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 73dd5a5d249c1f73fcfdd9bb272a4536aaceee5f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If anyone has time, it would be good to document this on https://book.kubebuilder.io/reference/markers/crd-validation. |
Agree. Although it will be only available via a release in August. Might be good to then go over the controller-tools release notes once kubebuilder bumps and update the docs accordingly /cc @camilamacedo86 |
We need to update the docs, I added the info in : kubernetes-sigs/kubebuilder#3794 (comment) |
Fixes #943
Adds support for Kubernetes
+required
annotations on fields, fixes support for+optional
annotations on fields, adds tests.