Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add support for kubernetes +required annotations #944

Merged
merged 1 commit into from
May 7, 2024

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented May 7, 2024

Fixes #943

Adds support for Kubernetes +required annotations on fields, fixes support for +optional annotations on fields, adds tests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcc1db5628bc614c8d0efd02ed32a6bccddf3a9c

@sbueringer
Copy link
Member

One minor finding

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed May 7, 2024 12:51
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73dd5a5d249c1f73fcfdd9bb272a4536aaceee5f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmetb
Copy link
Member

ahmetb commented May 29, 2024

If anyone has time, it would be good to document this on https://book.kubebuilder.io/reference/markers/crd-validation.

@sbueringer
Copy link
Member

Agree. Although it will be only available via a release in August.

Might be good to then go over the controller-tools release notes once kubebuilder bumps and update the docs accordingly
(there was also this PR: #938)

/cc @camilamacedo86

@camilamacedo86
Copy link
Member

We need to update the docs, I added the info in : kubernetes-sigs/kubebuilder#3794 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should respect +required
6 participants