Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRItest for invalid registry and bad signature error codes #1158

Open
SergeyKanzhelev opened this issue May 4, 2023 · 5 comments
Open

CRItest for invalid registry and bad signature error codes #1158

SergeyKanzhelev opened this issue May 4, 2023 · 5 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@SergeyKanzhelev
Copy link
Member

What would you like to be added:

As a follow up from kubernetes/kubernetes#117717 it will be great to create cri tests to ensure that the proper error messages are returned from the CRI implementation as CRI takes weak dependency on those.

This may not work for every implementation, so need to validate it first and maybe have those tests as optional at first.

@SergeyKanzhelev SergeyKanzhelev added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 4, 2023
@saschagrunert
Copy link
Member

Sounds like a good plan!

/help

@k8s-ci-robot
Copy link
Contributor

@saschagrunert:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Sounds like a good plan!

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 5, 2023
@saschagrunert saschagrunert added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 5, 2023
@sohankunkerkar
Copy link
Member

/assign @sohankunkerkar

@sohankunkerkar
Copy link
Member

@SergeyKanzhelev @saschagrunert, I believe we need to create two separate images in order to test the ErrRegistryUnavailable and ErrSignatureValidationFailed errors. I assume the placeholder for these two images would be located at gcr.io/k8s-staging-cri-tools/. However, I do not have access to create the images in that repository. Is it possible for someone to assist me in creating those two images there?

@saschagrunert
Copy link
Member

ErrRegistryUnavailable can be tested by referring to a xyz.local registry where we ensure that it does not exist. Maybe by using a random hostname and double checking that no registry is running there.

The images in gcr.io/k8s-staging-cri-tools/ are not signed, so they may already qualify for a ErrSignatureValidationFailed test depending on how we configure the container runtime.

sohankunkerkar added a commit to sohankunkerkar/cri-tools that referenced this issue May 18, 2023
…odes

Fixes: kubernetes-sigs#1158
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
sohankunkerkar added a commit to sohankunkerkar/cri-tools that referenced this issue May 18, 2023
…odes

Fixes: kubernetes-sigs#1158
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

4 participants