Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox config to image pull #375

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Add sandbox config to image pull #375

merged 1 commit into from
Sep 7, 2018

Conversation

jterry75
Copy link
Contributor

@jterry75 jterry75 commented Sep 6, 2018

Adds the sandbox config to the image pull command so a config can
contain the podsandbox context to pull the image in.

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2018
Adds the sandbox config to the image pull command so a config can
contain the podsandbox context to pull the image in.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@feiskyer
Copy link
Member

feiskyer commented Sep 7, 2018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 7, 2018
@feiskyer
Copy link
Member

feiskyer commented Sep 7, 2018

LGTM, but let's wait a while for #376 because the repo has been moved to new org.

@feiskyer feiskyer closed this Sep 7, 2018
@feiskyer feiskyer reopened this Sep 7, 2018
@feiskyer
Copy link
Member

feiskyer commented Sep 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2018
@feiskyer
Copy link
Member

feiskyer commented Sep 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, jterry75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit e92c5ec into kubernetes-sigs:master Sep 7, 2018
@jterry75 jterry75 deleted the add_pull_config branch September 7, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants