-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crictl inspecti fail to unmarshal #378
Conversation
Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
3de7df8
to
7f150d5
Compare
test record: when ImageStatus return success:
when ImageStatus return error:
|
Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
@@ -224,7 +224,7 @@ func outputStatusInfo(status string, info map[string]string, format string) erro | |||
for _, k := range keys { | |||
var res interface{} | |||
// We attempt to convert key into JSON if possible else use it directly | |||
if err := json.Unmarshal([]byte(info[k]), res); err != nil { | |||
if err := json.Unmarshal([]byte(info[k]), &res); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
Thanks for the fix. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: yanxuean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: yanxuean yan.xuean@zte.com.cn
The crictl inspecti can't work.
It always return error "err=json: Unmarshal(nil)" for json.Unmarshal.