-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime handler support #383
Add runtime handler support #383
Conversation
@Random-Liu: GitHub didn't allow me to request PR reviews from the following users: tallclair. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lantao Liu <lantaol@google.com>
b491fee
to
e31ab6e
Compare
cmd/crictl/logs.go
Outdated
@@ -17,6 +17,7 @@ limitations under the License. | |||
package main | |||
|
|||
import ( | |||
gocontext "context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change variable name from context
to ctx
in this file, and just import the context
package as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Awesome, thanks for this! |
Signed-off-by: Lantao Liu <lantaol@google.com>
e31ab6e
to
49a5dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes #382.
Example for containerd:
/cc @yujuhong @tallclair