Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a benchmark testcase for measuring the time of creating pod and a container #419

Merged
merged 3 commits into from
Jan 24, 2019
Merged

add a benchmark testcase for measuring the time of creating pod and a container #419

merged 3 commits into from
Jan 24, 2019

Conversation

lifupan
Copy link
Contributor

@lifupan lifupan commented Dec 21, 2018 •
edited
Loading

add a benchmark testcase for measuring the time of creating pod and a container, plus some fixes.

@lifupan
benchmark: fix the issue of empty container ids
3a36858 
Init a slice with length 0, otherwise it will init
it with capability as length and the following append
operation will append the value and there will be
"length" zero value in front.

Signed-off-by: Fupan Li <lifupan@gmail.com>
@lifupan
benchmark: expand the timeout from 2 to 5 for creating a pod
5f10256 
For some hypervisor based containers, it would take much longer
time to create a pod, thus it's better expand the tiemout value
from 2 to 5 to avoid timeout errors.

Signed-off-by: Fupan Li <lifupan@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 21, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2018
@lifupan
Copy link
Contributor Author

lifupan commented Dec 21, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 21, 2018
@lifupan
Copy link
Contributor Author

lifupan commented Dec 22, 2018

Hi @Random-Liu
It seems there is one testcase failed in travis, but I cannot find what's the root cause.
Could you have a look?

egernst
egernst reviewed Jan 2, 2019
View reviewed changes
pkg/benchmark/README.md Outdated
```sh
go get github.com/kata-containers/runtime
pushd $GOPATH/src/github.com/kata-containers/runtime
git remote add hyper https://github.com/hyperhq/kata-runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there deltas between upstream Kata Containers and the hyperhq version still? I'd prefer to see testing done against upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice catch. I forgot to update it to master.
Updated.

pkg/benchmark/README.md Outdated
### Install critest

```sh
go get https://github.com/lifupan/cri-tools.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as above - once this lands, the upstream version should suffice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

feiskyer
feiskyer reviewed Jan 3, 2019
View reviewed changes
pkg/benchmark/README.md Outdated Show resolved Hide resolved
@gnawux
Copy link

gnawux commented Jan 4, 2019

This PR is not Kata-specific, on the contrary, it introduces some more cases, which are cared about more in the multi-runtime scenarios.

For the README file, it described how to test with Kata Containers, which is not directly related with the cases, and should be claimed as an example.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2019
@lifupan lifupan changed the title Kata container support for benchmarking add a benchmark testcase for measuring the time of creating pod and a container Jan 4, 2019
@lifupan
benchmark: add a testcase for creating a pod and a container
42cb1cf 
Add a testcase for measuring the time of creating a pod
and container.

Signed-off-by: Fupan Li <lifupan@gmail.com>
@lifupan
Copy link
Contributor Author

lifupan commented Jan 17, 2019

Hi @Random-Liu Any comments?

feiskyer
feiskyer reviewed Jan 24, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lifupan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd69210 into kubernetes-sigs:master Jan 24, 2019
@lifupan lifupan deleted the kata_support branch January 29, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@egernst egernst egernst left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lifupan @k8s-ci-robot @gnawux @feiskyer @egernst