This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Merge in upstream changes to etcd-manager #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mmerrill3 <michael.merrill@vonage.com>
This addresses the deeper client-certificate validation introduced in etcd 3.2, without relying on DNS.
Previously we assumed that if our peers didn't change and we had the leadership, that the peers would continue to acknowledge our leadership. But this assumes that a peer didn't restart or crash. Instead, on every leader iteration, check with all the peers that we are still the leader (using the same GRPC method). For negligible additional traffic, this should enable greater recovery from errors and greater consistency of leader election. Issue kubernetes-retired#348
This commit adds klog.V(3).Infof instead of plain klog.Infof for frequently occuring informational events.
k8s-ci-robot
added
cncf-cla: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes:
3.0.20210122
3.0.20210228