Skip to content

Commit

Permalink
Restore cluster role permissions to read services when Istio sources …
Browse files Browse the repository at this point in the history
…are enabled
  • Loading branch information
haines committed Nov 12, 2021
1 parent c82a3d2 commit 4b4f11a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions charts/external-dns/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: external-dns
description: ExternalDNS synchronizes exposed Kubernetes Services and Ingresses with DNS providers.
type: application
version: 1.6.0
version: 1.6.1
appVersion: 0.10.1
keywords:
- kubernetes
Expand All @@ -17,5 +17,5 @@ maintainers:
email: steve.hipwell@gmail.com
annotations:
artifacthub.io/changes: |
- kind: changed
description: "Allow specifying Service annotations."
- kind: fixed
description: "Restore cluster role permissions to read services when Istio sources are enabled"
2 changes: 1 addition & 1 deletion charts/external-dns/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ rules:
verbs: ["get","watch","list"]
{{- end }}

{{- if has "service" .Values.sources }}
{{- if or (has "service" .Values.sources) (has "istio-gateway" .Values.sources) (has "istio-virtualservice" .Values.sources) }}
- apiGroups: [""]
resources: ["services","endpoints"]
verbs: ["get","watch","list"]
Expand Down

0 comments on commit 4b4f11a

Please sign in to comment.