Merge pull request #4068 from mikkeloscar/routegroup-ipv6-compatible

Make routegroup client IPv6 compatible
kubernetes-sigs · Nov 27, 2023 · 4d04113 · 4d04113
2 parents a60480f + b48bb26
commit 4d04113
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/source/skipper_routegroup.go b/source/skipper_routegroup.go
@@ -210,7 +210,8 @@ func NewRouteGroupSource(timeout time.Duration, token, tokenPath, apiServerURL,
 	apiServer := u.String()
 	// strip port if well known port, because of TLS certificate match
 	if u.Scheme == "https" && u.Port() == "443" {
-		apiServer = "https://" + u.Hostname()
+		// correctly handle IPv6 addresses by keeping surrounding `[]`.
+		apiServer = "https://" + strings.TrimSuffix(u.Host, ":443")
 	}
 
 	sc := &routeGroupSource{