chore(chart): Adding extra containers (#4432)

* Added extra containers to deployment

* Added option to disable/enable service

* Add comment

* Update helm docs

* Added space at the end

* Return service monitor to false

* Set service default to true

* Add support for extraContainers and remove
service.create

* Fix container name in values.yaml

* Ran helm-docs

charts/external-dns/CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Added
 
+- Added support for `extraContainers` argument. ([#4432](https://github.com/kubernetes-sigs/external-dns/pull/4432))[@omerap12](https://github.com/omerap12)
 - Added support for setting `excludeDomains` argument.  ([#4380](https://github.com/kubernetes-sigs/external-dns/pull/4380))[@bford-evs](https://github.com/bford-evs)
 
 ## [v1.14.4] - 2023-04-03

charts/external-dns/README.md

@@ -101,6 +101,7 @@ If `namespaced` is set to `true`, please ensure that `sources` my only contains
 | env | list | `[]` | [Environment variables](https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/) for the `external-dns` container. |
 | excludeDomains | list | `[]` |  |
 | extraArgs | list | `[]` | Extra arguments to provide to _ExternalDNS_. |
+| extraContainers | object | `{}` | Extra containers to add to the `Deployment`. |
 | extraVolumeMounts | list | `[]` | Extra [volume mounts](https://kubernetes.io/docs/concepts/storage/volumes/) for the `external-dns` container. |
 | extraVolumes | list | `[]` | Extra [volumes](https://kubernetes.io/docs/concepts/storage/volumes/) for the `Pod`. |
 | fullnameOverride | string | `nil` | Override the full name of the chart. |

charts/external-dns/templates/deployment.yaml

@@ -70,6 +70,9 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       containers:
+      {{- with .Values.extraContainers }}
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
         - name: external-dns
           {{- with .Values.securityContext }}
           securityContext:

charts/external-dns/values.yaml

@@ -53,6 +53,9 @@ rbac:
 # -- Annotations to add to the `Deployment`.
 deploymentAnnotations: {}
 
+# -- Extra containers to add to the `Deployment`.
+extraContainers: {}
+
 # -- [Deployment Strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy).
 deploymentStrategy:
   type: Recreate