fix: Allow revisionHistoryLimit to be set to 0

Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
kubernetes-sigs · Dec 7, 2023 · 7c595b9 · 7c595b9
1 parent e1adc90
commit 7c595b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -16,8 +16,8 @@ spec:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
   strategy:
     {{- toYaml .Values.deploymentStrategy | nindent 4 }}
-  {{- with .Values.revisionHistoryLimit }}
-  revisionHistoryLimit: {{ . }}
+  {{- if or (kindIs "float64" .Values.revisionHistoryLimit) (kindIs "int64" .Values.revisionHistoryLimit) }}
+  revisionHistoryLimit: {{ .Values.revisionHistoryLimit | int64 }}
   {{- end }}
   template:
     metadata:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -197,7 +197,7 @@ secretConfiguration:
 deploymentStrategy:
   type: Recreate
 
-# Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
+# Specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
 revisionHistoryLimit:
 
 # opt out of the service account token automounting (at the pod level)