Allow to configure revisionHistoryLimit on the K8s Deployment resource (

#4008) * Allow to configure revisionHistoryLimit on the K8s Deployment resource Signed-off-by: Arnold Bechtoldt <mail@arnoldbechtoldt.com> * Extend Helm chart CHANGELOG with new revisionHistoryLimit feature Signed-off-by: Arnold Bechtoldt <mail@arnoldbechtoldt.com> --------- Signed-off-by: Arnold Bechtoldt <mail@arnoldbechtoldt.com>
kubernetes-sigs · Nov 10, 2023 · 8b290b5 · 8b290b5
1 parent 4941d0c
commit 8b290b5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Added the option to explicitly enable or disable service account token automounting. ([#3983](https://github.com/kubernetes-sigs/external-dns/pull/3983)) [@gilles-gosuin](https://github.com/gilles-gosuin)
+- Added the option to configure revisionHistoryLimit on the K8s Deployment resource. ([#4008](https://github.com/kubernetes-sigs/external-dns/pull/4008)) [@arnisoph](https://github.com/arnisoph)
 
 ## [v1.13.1] - 2023-09-07
 

diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -86,6 +86,7 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
 | `secretConfiguration.data`                    | Secret configuration secret data. Could be used to store DNS provider credentials.                                                                                                                                                                                                                                    | `{}`                                        |
 | `secretConfiguration.subPath`                 | Sub-path of secret configuration secret (this can be templated).                                                                                                                                                                                                                                                      | `""`                                        |
 | `automountServiceAccountToken`                | Opt out of the [service account token automounting feature](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#opt-out-of-api-credential-automounting) for the pod                                                                                                                   | `null`                                      |
+| `revisionHistoryLimit`                        | Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.                                                                                                                                                                                                          | `null`                                      |
 
 ## Namespaced scoped installation
 

diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -16,6 +16,9 @@ spec:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
   strategy:
     {{- toYaml .Values.deploymentStrategy | nindent 4 }}
+  {{- with .Values.revisionHistoryLimit }}
+  revisionHistoryLimit: {{ . }}
+  {{- end }}
   template:
     metadata:
       labels:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -197,5 +197,8 @@ secretConfiguration:
 deploymentStrategy:
   type: Recreate
 
+# Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
+revisionHistoryLimit:
+
 # opt out of the service account token automounting (at the pod level)
 automountServiceAccountToken: