Changed the Deployment strategy to 'Recreate' so multiple external-dn…

…s pods don't conflict with each other. Signed-off-by: Mac Chaffee <machaffe@renci.org>
kubernetes-sigs · May 26, 2022 · ac675e5 · ac675e5
1 parent 347a2bf
commit ac675e5
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md
@@ -13,13 +13,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Deprecated
 ### Removed -->
 
-## [v1.9.0] - UNRELEASED
+## [v1.9.1]
+
+### Changed
+
+- Changed the Deployment strategy to "Recreate" so multiple external-dns pods don't conflict with each other. [#9999]()
+
+## [v1.9.0]
 
 ### Changed
 
 - Update _ExternalDNS_ version to [v0.11.0](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.11.0).
 
-## [v1.8.0] - UNRELEASED
+## [v1.8.0]
 
 ### Added
 

diff --git a/charts/external-dns/Chart.yaml b/charts/external-dns/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: external-dns
 description: ExternalDNS synchronizes exposed Kubernetes Services and Ingresses with DNS providers.
 type: application
-version: 1.9.0
+version: 1.9.1
 appVersion: 0.11.0
 keywords:
   - kubernetes
@@ -20,4 +20,4 @@ maintainers:
 annotations:
   artifacthub.io/changes: |
     - kind: changed
-      description: "Update ExternalDNS version to v0.11.0"
+      description: "Changed the Deployment strategy to 'Recreate' so multiple external-dns pods don't conflict with each other."
diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -69,3 +69,4 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
 | `domainFilters`                   | Limit possible target zones by domain suffixes.                                                                                                                                                                                                                                                                       | `[]`                                   |
 | `provider`                        | DNS provider where the DNS records will be created, for the available providers and how to configure them see the [README](https://github.com/kubernetes-sigs/external-dns#deploying-to-a-cluster).                                                                                                                   | `aws`                                  |
 | `extraArgs`                       | Extra arguments to pass to the _external-dns_ container, these are needed for provider specific arguments.                                                                                                                                                                                                            | `[]`                                   |
+| `deploymentStrategy`              | .spec.strategy of the external-dns Deployment. Defaults to 'Recreate' since multiple external-dns pods may conflict with each other.                                                                                                                                                                                  | `{type: Recreate}`                     |
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -13,6 +13,8 @@ spec:
   selector:
     matchLabels:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
+  strategy:
+    {{- toYaml .Values.deploymentStrategy | nindent 4 }}
   template:
     metadata:
       labels:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -118,3 +118,6 @@ domainFilters: []
 provider: aws
 
 extraArgs: []
+
+deploymentStrategy:
+  type: Recreate