Apply suggestions from code review

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
kubernetes-sigs · Nov 9, 2023 · b83935b · b83935b
1 parent 4a8dbc5
commit b83935b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/registry/dynamodb.go b/registry/dynamodb.go
@@ -477,6 +477,7 @@ func (im *DynamoDBRegistry) appendDelete(statements []*dynamodb.BatchStatementRe
 func (im *DynamoDBRegistry) executeStatements(ctx context.Context, statements []*dynamodb.BatchStatementRequest, handleErr func(request *dynamodb.BatchStatementRequest, response *dynamodb.BatchStatementResponse) error) error {
 	for len(statements) > 0 {
 		var chunk []*dynamodb.BatchStatementRequest
+                // DynamoDB allows a maximum batch size of 25 items.
 		if len(statements) > 25 {
 			chunk = statements[:25]
 			statements = statements[25:]

diff --git a/registry/dynamodb_test.go b/registry/dynamodb_test.go
@@ -295,7 +295,7 @@ func TestDynamoDBRegistryApplyChanges(t *testing.T) {
 			},
 		},
 		{
-			name: "create many",
+			name: "create more entries than DynamoDB batch size limit (25)",
 			changes: plan.Changes{
 				Create: []*endpoint.Endpoint{
 					{