fix: Allow revisionHistoryLimit to be set to 0

Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
kubernetes-sigs · Dec 7, 2023 · b9c761d · b9c761d
1 parent 25f8242
commit b9c761d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -16,8 +16,8 @@ spec:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
   strategy:
     {{- toYaml .Values.deploymentStrategy | nindent 4 }}
-  {{- with .Values.revisionHistoryLimit }}
-  revisionHistoryLimit: {{ . }}
+  {{- if or (kindIs "float64" .Values.revisionHistoryLimit) (kindIs "int64" .Values.revisionHistoryLimit) }}
+  revisionHistoryLimit: {{ .Values.revisionHistoryLimit | int64 }}
   {{- end }}
   template:
     metadata:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -228,3 +228,6 @@ secretConfiguration:
   subPath:
   # -- `Secret` data.
   data: {}
+
+# Specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
+revisionHistoryLimit: