Skip to content

Commit

Permalink
Allow to configure revisionHistoryLimit on the K8s Deployment resource
Browse files Browse the repository at this point in the history
Signed-off-by: Arnold Bechtoldt <mail@arnoldbechtoldt.com>
  • Loading branch information
arnisoph committed Nov 10, 2023
1 parent e6d7386 commit d699cc7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/external-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
| `secretConfiguration.data` | Secret configuration secret data. Could be used to store DNS provider credentials. | `{}` |
| `secretConfiguration.subPath` | Sub-path of secret configuration secret (this can be templated). | `""` |
| `automountServiceAccountToken` | Opt out of the [service account token automounting feature](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#opt-out-of-api-credential-automounting) for the pod | `null` |
| `revisionHistoryLimit` | Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment. | `null` |

## Namespaced scoped installation

Expand Down
3 changes: 3 additions & 0 deletions charts/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ spec:
{{- include "external-dns.selectorLabels" . | nindent 6 }}
strategy:
{{- toYaml .Values.deploymentStrategy | nindent 4 }}
{{- with .Values.revisionHistoryLimit }}
revisionHistoryLimit: {{ . }}
{{- end }}
template:
metadata:
labels:
Expand Down
3 changes: 3 additions & 0 deletions charts/external-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -197,5 +197,8 @@ secretConfiguration:
deploymentStrategy:
type: Recreate

# Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
revisionHistoryLimit:

# opt out of the service account token automounting (at the pod level)
automountServiceAccountToken:

0 comments on commit d699cc7

Please sign in to comment.