Merge pull request #3734 from fad3t/ambassador-external-ip

feat: add support for external IP in ambassador host source
kubernetes-sigs · Oct 27, 2023 · d8f408b · d8f408b
2 parents 8bc1c20 + 73862a8
commit d8f408b
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/source/ambassador_host.go b/source/ambassador_host.go
@@ -185,7 +185,7 @@ func (sc *ambassadorHostSource) endpointsFromHost(ctx context.Context, host *amb
 	return endpoints, nil
 }
 
-func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Context, service string) (targets endpoint.Targets, err error) {
+func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Context, service string) (endpoint.Targets, error) {
 	lbNamespace, lbName, err := parseAmbLoadBalancerService(service)
 	if err != nil {
 		return nil, err
@@ -196,16 +196,9 @@ func (sc *ambassadorHostSource) targetsFromAmbassadorLoadBalancer(ctx context.Co
 		return nil, err
 	}
 
-	for _, lb := range svc.Status.LoadBalancer.Ingress {
-		if lb.IP != "" {
-			targets = append(targets, lb.IP)
-		}
-		if lb.Hostname != "" {
-			targets = append(targets, lb.Hostname)
-		}
-	}
+	var targets = extractLoadBalancerTargets(svc, true)
 
-	return
+	return targets, nil
 }
 
 // parseAmbLoadBalancerService returns a name/namespace tuple from the annotation in