fix: Allow revisionHistoryLimit to be set to 0

kubernetes-sigs · Nov 16, 2023 · df11bc6 · df11bc6
1 parent e1adc90
commit df11bc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -16,9 +16,7 @@ spec:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
   strategy:
     {{- toYaml .Values.deploymentStrategy | nindent 4 }}
-  {{- with .Values.revisionHistoryLimit }}
-  revisionHistoryLimit: {{ . }}
-  {{- end }}
+  revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   template:
     metadata:
       labels:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -197,8 +197,8 @@ secretConfiguration:
 deploymentStrategy:
   type: Recreate
 
-# Optional field that specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
-revisionHistoryLimit:
+# Specifies the number of old ReplicaSets to retain to allow rollback with the Deployment.
+revisionHistoryLimit: 10
 
 # opt out of the service account token automounting (at the pod level)
 automountServiceAccountToken: