Failing tests in the Cloudflare provider

[mikejoh]

What happened:
When making changes to my PR i noticed that the build / test step failed with the following error message in the Cloudflare tests:

time="2022-11-22T08:56:40Z" level=error msg="failed to find previous record: {0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC  foobar.bar.com target <nil> <nil>    <nil> 1 0xc000525d8f false false}" action=DELETE record=foobar.bar.com ttl=1 type= zone=001
--- FAIL: TestProviderPropertiesIdempotency (0.00s)
    --- FAIL: TestProviderPropertiesIdempotency/ProxyDefault:_true,_ShouldBeProxied:_false,_ExpectUpdates:_true (0.00s)
        cloudflare_test.go:1090: 
            	Error Trace:	/home/runner/work/external-dns/external-dns/provider/cloudflare/cloudflare_test.go:1090
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestProviderPropertiesIdempotency/ProxyDefault:_true,_ShouldBeProxied:_false,_ExpectUpdates:_true
            	Messages:   	should not have new updates
        cloudflare_test.go:1091: 
            	Error Trace:	/home/runner/work/external-dns/external-dns/provider/cloudflare/cloudflare_test.go:1091
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestProviderPropertiesIdempotency/ProxyDefault:_true,_ShouldBeProxied:_false,_ExpectUpdates:_true
            	Messages:   	should not have old updates
    --- FAIL: TestProviderPropertiesIdempotency/ProxyDefault:_false,_ShouldBeProxied:_true,_ExpectUpdates:_true (0.00s)
        cloudflare_test.go:1090: 
            	Error Trace:	/home/runner/work/external-dns/external-dns/provider/cloudflare/cloudflare_test.go:1090
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestProviderPropertiesIdempotency/ProxyDefault:_false,_ShouldBeProxied:_true,_ExpectUpdates:_true
            	Messages:   	should not have new updates
        cloudflare_test.go:1091: 
            	Error Trace:	/home/runner/work/external-dns/external-dns/provider/cloudflare/cloudflare_test.go:1091
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestProviderPropertiesIdempotency/ProxyDefault:_false,_ShouldBeProxied:_true,_ExpectUpdates:_true
            	Messages:   	should not have old updates
time="2022-11-22T08:56:40Z" level=info msg="Changing record." action=DELETE record=foobar.bar.com ttl=120 type=A zone=001
time="2022-11-22T08:56:40Z" level=info msg="Changing record." action=CREATE record=foobar.bar.com ttl=1 type=A zone=001
time="2022-11-22T08:56:40Z" level=info msg="Changing record." action=UPDATE record=foobar.bar.com ttl=1 type=A zone=001
FAIL

I haven't had time to deep dive into this unfortunately. It might be due to a regression bug introduced in a recent commit.

Example of a failing test: https://github.com/kubernetes-sigs/external-dns/actions/runs/3522523043/jobs/5905598655

What you expected to happen:
Test tests to succeed!

How to reproduce it (as minimally and precisely as possible):

git clone https://github.com/kubernetes-sigs/external-dns
go test -race -coverprofile=profile.cov ./...

Anything else we need to know?:

Environment:

• External-DNS version (use external-dns --version): master
• DNS provider:
• Others:

[mikejoh]

This commit seems to have introduced the failing tests: ca07f0a. Moving back to a commit before this one makes the tests pass in the Cloudflare provider. There's a fix being added here: #3180 although those tests also fails at the moment.

[mikejoh]

The commit, that introduced the regression bug causing the failing tests, was reverted: #3199

The tests now works! Closing this issue.