Add F5 Networks VirtualServer source

[mikejoh]

Description
This PR adds support for the F5 Networks VirtualServer CRD as a source of creating endpoints.

Partly fixes #2739 since this PR adds support for only the VirtualServer CRD and not the TransportServer one. I believe it make sense to keep these separated in terms of PRs.

Checklist

• Unit tests updated
• End user documentation updated
• Squash commits

[stevehipwell]

@mikejoh I can't review your actual code here but as the Helm chart maintainer could I request that you remove the chart changes from this PR and submit them once the new source has been merged? The binary and Helm release lifecycles aren't aligned so it doesn't make sense having them in a single PR.

[mikejoh]

@mikejoh I can't review your actual code here but as the Helm chart maintainer could I request that you remove the chart changes from this PR and submit them once the new source has been merged? The binary and Helm release lifecycles aren't aligned so it doesn't make sense having them in a single PR.

Check! Fixed here: 7f3c4ed. I'll create a new PR when this one is merged.

[mikejoh]

/retest

[k8s-ci-robot]

@mikejoh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

/ok-to-test
/retest

[mikejoh]

@stevehipwell Do you have any idea what's going on with those failing tests in the Cloudflare provider? Might be a regression bug? Issue: #3179

[stevehipwell]

@mikejoh sorry I don't know. You could push a minor change (e.g. git commit --amend --no-edit && git push --force-with-lease) to re-trigger the tests as the Prow command has no impact on GH Actions.

[mikejoh]

@mikejoh sorry I don't know. You could push a minor change (e.g. git commit --amend --no-edit && git push --force-with-lease) to re-trigger the tests as the Prow command has no impact on GH Actions.

@stevehipwell Great, thanks, good to know! 👍🏻 I'll wait a while until the tests are fixed.

[mikejoh]

/retest

[mikejoh]

@seanmalloy Hi! 👋, would it be possible for someone to take a look at this PR? I can understand, by looking at the amount of PRs and issues, that all maintainers here have a lot to do!

[mikejoh]

@szuecs Hi! 👋, would it be possible to take a look at this PR? I've understood that a lot of work is going into the plugin provider and that reviewing PRs adding/changing providers has been postponed. How is it with PRs and code touching Source's?

Thanks!

[adubkov]

Would love to have this PR merged.

[szuecs]

Thanks for the pr but we won't review no merge any new providers. Providers will be enabled to use a webhook. Pleas check #3063 , you can adapt your code to integrate with this interface and it will work.

[mikejoh]

Thanks for the pr but we won't review no merge any new providers. Providers will be enabled to use a webhook. Pleas check #3063 , you can adapt your code to integrate with this interface and it will work.

@szuecs This PR "only" touches the Source side of things here, not a provider. Or have i misunderstood something? Thanks!

[szuecs]

@mikejoh yeah true I see it now. Sorry I did not check the source yet.

[vinylen]

Can this be merged? This would be really useful to have

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikejoh, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

/lgtm