[bitnami/external-dns] Add RBAC to support F5 VirtualServer external-dns source #15804
Conversation
|
@javsalgar 👋 would it be possible to review this one? Thanks! |
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
There was a problem hiding this comment.
Thanks for the contribution @mikejoh !
I just left you a minor comment above.
bitnami/external-dns/Chart.yaml
Outdated
| @@ -24,4 +24,4 @@ sources: | |||
| - https://github.com/kubernetes-sigs/external-dns | |||
| - https://github.com/bitnami/containers/tree/main/bitnami/external-dns | |||
| - https://github.com/kubernetes-sigs/external-dns | |||
| version: 6.15.0 | |||
| version: 6.15.1 | |||
There was a problem hiding this comment.
Adding functionality should imply a minor bump (Semver summary)
| version: 6.15.1 | |
| version: 6.16.0 |
There was a problem hiding this comment.
Ah, of course, fixed here: c4d3d45
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
|
@aoterolorenzo Sorry for pinging in the PR but i just saw that the pipeline triggered on merge to Is that expected? 🤔 Let me know if there's something i can do! |
…dns source (#15804) * Add RBAC to support F5 VirtualServer external-dns source Signed-off-by: Mikael Johansson <mik.json@gmail.com> * Bump minor version Signed-off-by: Mikael Johansson <mik.json@gmail.com> --------- Signed-off-by: Mikael Johansson <mik.json@gmail.com>
Hi @mikejoh, seems there was a collision when merging two PR's with same version near each other on time. I saw you just bump a minor in #15968 and this indeed have triggered a chart release. |
Description of the change
With these recently merged PRs in upstream:
kubernetes-sigs/external-dns#3503 - RBAC added upstream in
external-dnshelm chart.kubernetes-sigs/external-dns#3162 - code changes in
external-dns.we now need to add the same RBAC to this chart to be able to configure
external-dnsto list F5VirtualServerobjects in the cluster.Benefits
We'll be able to configure the
--source=f5-virtualserverflag which instructsexternal-dnsto list allVirtualServerobjects in the cluster, these objects will be used as a source to create DNS records in the given provider.Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm