Add RBAC to be able to handle F5 VirtualServer source #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
stevehipwell
suggested changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks for the PR, this looks good @mikejoh but could you add a new unreleased section to the chart CHANGELOG to cover your changes so they get documented when the next release comes out.
mikejoh
force-pushed
the
add-f5-virtualserver-source-rbac
branch
from
b39e8f0
to
fa797d1
Compare
k8s-ci-robot
added
size/S
mikejoh
force-pushed
the
add-f5-virtualserver-source-rbac
branch
from
8569301
to
cea0905
Compare
|
@stevehipwell Done! |
|
@mikejoh could you squash your commits? |
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
mikejoh
force-pushed
the
add-f5-virtualserver-source-rbac
branch
from
cea0905
to
d2932e3
Compare
@stevehipwell of course, done! |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikejoh, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RBAC to be able to handle F5 VirtualServer
Source. Support for F5 VirtualServers were added here: #3162.Checklist