Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric] last_sync_timestamp_seconds is misleading #3339

Closed
gozer opened this issue Jan 26, 2023 · 2 comments · Fixed by #3340
Closed

[metric] last_sync_timestamp_seconds is misleading #3339

gozer opened this issue Jan 26, 2023 · 2 comments · Fixed by #3340
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gozer
Copy link
Contributor

gozer commented Jan 26, 2023

What would you like to be added:

I would like 2 distinct metrics to track the last sync timestamp of the main reconciliation loop.

The current last_sync_timestamp_seconds that I wish was called last_successful_sync_timestamp_seconds

And one last_reconcile_timestamp_seconds that recorded a new timestamp for the reconcile loop, wether it completed successfully or not.

Why is this needed:

Right now, I can't differentiate between the sync loop lagging because the operator is overworked or some timing issues from an error encountered during a reconciliation pass.

@gozer gozer added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2023
gozer added a commit to gozer/k8s-external-dns that referenced this issue Jan 26, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2023
@gozer
Copy link
Contributor Author

gozer commented Apr 26, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants