Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wrong record type for top level domains #3787

Closed
davidgiga1993 opened this issue Jul 14, 2023 · 5 comments
Closed

Using wrong record type for top level domains #3787

davidgiga1993 opened this issue Jul 14, 2023 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@davidgiga1993
Copy link

What happened:
External DNS tries to create a CNAME record for a top-level domain of a route53 zone instead of an A record.

What you expected to happen:
Either
a) External DNS should detect if it's possible to create a CNAME and if not fallback to another record type
or
b) Allow the user to specify the record type via an annotation.

I would be happy with either solution and would be willing to implement this change. Just needs some discussion first what approach should be used

How to reproduce it (as minimally and precisely as possible):

  1. Create a route53 zone
  2. Create an ingress which uses the top level domain
  3. See logs:
Failure in zone mydomain.com. [Id: /hostedzone/Z08072521A81YX2VJ0B4V] when submitting change batch: InvalidChangeBatch: [RRSet of type CNAME with DNS name mydomain.com. is not permitted at apex in zone mydomain.com. status code: 400, request id: e1371e8e-86d5-461f-be1e-a0a7048e6be6"

Anything else we need to know?:
Arguments:

"--source=ingress",
"--source=service",
"--provider=aws",
"--aws-zone-type=public",
"--registry=txt",
"--txt-owner-id=${var.record_owner}",
"--txt-prefix=${var.dns_txt_prefix}",
# Use a batch size of 1 to make sure
# a single failed update doesn't block the entire batch
"--aws-batch-change-size=1",
"--log-level=debug"

Environment:

  • External-DNS version (use external-dns --version): v20230327-v0.13.4
  • DNS provider: AWS route53
  • Others: k8s v1.27.3-eks-a5565ad
@davidgiga1993 davidgiga1993 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 14, 2023
@astateful
Copy link

astateful commented Jul 29, 2023

Would also like to throw my hat in the ring and report that I am facing the exact same issue with external-dns v0.13.5 and vultr as my DNS provider as well as k8s version 1.27.2. Reverting to version v0.12.2 fixes the behaviour such that A records are being generated again. The following are the arguments being passed:

- '--source=ingress'
- '--domain-filter=...'
- '--provider=vultr'

Setting a txt-prefix did not solve the issue either.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants