Gateway HTTPRoute doesn't matched hosts with different number of parts

[sergeyshevch]

What happened:

https://github.com/kubernetes-sigs/external-dns/blob/master/source/gateway.go#L507 On this line checked the same amount of domain parts, but for Gateway API spec it doesn't required

For example, I have:
HttpRoute with hostname - env.dev.company.domain
And Gateway with hostname - *.company.domain

External DNS controller will ignore such route but it's valid on Gateway side

What you expected to happen:

Domain matched, DNS record created

How to reproduce it (as minimally and precisely as possible):

Gateway:

apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: rest-external
spec:
  gatewayClassName: cilium
  listeners:
    - allowedRoutes:
        namespaces:
          from: All
      hostname: '*.example.com'
      name: web-gw
      port: 443
      protocol: HTTP

Route:

apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: route
spec:
  hostnames:
    - mr1.dev.example.com
  parentRefs:
    - group: gateway.networking.k8s.io
      kind: Gateway
      name: rest-external
  rules:
    - backendRefs:
        - group: ""
          kind: Service
          name: svcname
          port: 8080
          weight: 1
      matches:
        - path:
            type: PathPrefix
            value: /

Anything else we need to know?:

Environment:

• External-DNS version (use external-dns --version): v20230529-v0.13.5
• DNS provider: Route53
• Others: Gateway controller - Cilium

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sergeyshevch]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[igor-nikiforov]

/remove-lifecycle stale

[igor-nikiforov]

This issue is still huge blocker for migration from Ingress resource

[abursavich]

This was fixed with #4124 7 months ago.

[sergeyshevch]

Then let's close it
/close

[k8s-ci-robot]

@sergeyshevch: Closing this issue.

In response to this:

Then let's close it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.