Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for User API tokens to be used with DNSimple #4273

Closed
IntegralProgrammer opened this issue Feb 21, 2024 · 0 comments · Fixed by #4274
Closed

Allow for User API tokens to be used with DNSimple #4273

IntegralProgrammer opened this issue Feb 21, 2024 · 0 comments · Fixed by #4274
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@IntegralProgrammer
Copy link
Contributor

IntegralProgrammer commented Feb 21, 2024

What would you like to be added:

The ability to use User API tokens as opposed to only Account API tokens for interacting with the DNSimple API. Given that a User API token does not map to one specific account, the account ID would need to be specified via an environment variable (eg. DNSIMPLE_ACCOUNT_ID). Given that User API tokens do not allow for listing the DNS Zones of another DNSimple account (even if this user has access permissions to some of these zones), the DNS zones which External-DNS manipulates would need to be specified via environment variable (eg. DNSIMPLE_ZONES).

Why is this needed:

If the owner of a DNSimple account only wishes to give edit permissions to certain domains in that account, said owner could assign these permissions to a specific user and therefore a User API token and not an Account API token would need to be used for programmatically changing DNS records.

I have written a Pull Request to implement this feature - #4274.

@IntegralProgrammer IntegralProgrammer added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant