feat(DNSimple): User API tokens #4274

IntegralProgrammer · 2024-02-21T20:32:26Z

Description

This Pull Request introduces the following environment variables for overriding data retrieved from the DNSimple API. This is needed when using User API DNSimple tokens (as opposed to Account API DNSimple tokens) as this data cannot be accessed with a User API token:

DNSIMPLE_ACCOUNT_ID: The DNSimple account which owns the DNS records to be updated
DNSIMPLE_ZONES: A comma separated list of DNS Zones in DNSimple which External-DNS will be allowed to manipulate

Fixes #4273

Checklist

Unit tests updated
End user documentation updated

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables

linux-foundation-easycla · 2024-02-21T20:32:30Z

The committers listed above are authorized under a signed CLA.

✅ login: IntegralProgrammer / name: Michael Lescisin (660b20b, d475eb6, 9b3c285, 26694e4, acf188f, d0c121b, ea2d259, 3babcbc, 9c24ecc, 3eb852f, c54a9a8, 487501d, eb59b9b, ed3efdb)

k8s-ci-robot · 2024-02-21T20:32:35Z

Welcome @IntegralProgrammer!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-02-21T20:32:35Z

Hi @IntegralProgrammer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

szuecs · 2024-02-23T12:34:34Z

@IntegralProgrammer every feature requires a test.

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update documentation for these new environment variables

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update tests to check that the Zones function returns the correct DNS zones when the DNSIMPLE_ZONES environment variable is set

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update tests to check that the dnsimpleSuitableZone function works properly when the DNSIMPLE_ZONES environment variable is set

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Small refactoring to NewDnsimpleProvider function to improve its testability

…simpleProvider for testing its behavior when the DNSIMPLE_OAUTH environment variable is not set

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update tests to check that the BuildDnsimpleProvider function (called by the NewDnsimpleProvider function) handles the DNSIMPLE_ACCOUNT_ID environment variable properly

IntegralProgrammer · 2024-02-26T19:01:50Z

provider/dnsimple/dnsimple_test.go

 	os.Unsetenv("DNSIMPLE_OAUTH")
+	_, err = NewDnsimpleProvider(endpoint.NewDomainFilter([]string{"example.com"}), provider.NewZoneIDFilter([]string{""}), true)


This change wasn't really within the scope of this PR but this should be added in any case as without it, NewDnsimpleProvider isn't actually tested with an unset DNSIMPLE_OAUTH environment variable.

IntegralProgrammer · 2024-02-26T19:04:12Z

@IntegralProgrammer every feature requires a test.

Thank you for your feedback - I have added tests for this new feature in provider/dnsimple/dnsimple_test.go and have updated the documentation in docs/tutorials/dnsimple.md.

mloiseleur · 2024-03-04T07:59:58Z

/ok-to-test

mloiseleur · 2024-03-12T15:41:13Z

@IntegralProgrammer Thanks. Now you need to fix what is required by the linter. you can test it locally with make lint

mloiseleur · 2024-03-12T15:41:51Z

/retitle feat(DNSimple): User API tokens

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Fix code linting error - use !skipWhoami instead of skipWhoami == false

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Fix code linting error - remove () from ZonesFromZoneString which only returns one value

docs/tutorials/dnsimple.md

mloiseleur · 2024-03-15T08:19:16Z

provider/dnsimple/dnsimple.go

+	whoamiResponse := &dnsimple.WhoamiResponse{}
+	if !skipWhoami {
+		var err error
+		whoamiResponse, err = provider.identity.Whoami(context.Background())
+		if err != nil {
+			return nil, err
+		}
+	}
+
+	if dnsimpleAccountId == "" {
+		provider.accountID = int64ToString(whoamiResponse.Data.Account.ID)
+	} else {
+		provider.accountID = dnsimpleAccountId


Suggested change

whoamiResponse := &dnsimple.WhoamiResponse{}

if !skipWhoami {

var err error

whoamiResponse, err = provider.identity.Whoami(context.Background())

if err != nil {

return nil, err

}

}

if dnsimpleAccountId == "" {

provider.accountID = int64ToString(whoamiResponse.Data.Account.ID)

} else {

provider.accountID = dnsimpleAccountId

provider.accountID = dnsimpleAccountId

if provider.accountID == "" {

whoamiResponse, err := provider.identity.Whoami(context.Background())

if err != nil {

return nil, err

}

provider.accountID = int64ToString(whoamiResponse.Data.Account.ID)

I suggest to remove skipWhoami bool and also to avoid if ... else.
If you want to test also this part, you'll need to use mock.

Good suggestion - I have implemented this in 9c24ecc and 660b20b

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor the BuildDnsimpleProvider method so that it no longer needs the skipWhoami bool parameter

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Grammar fix in docs/tutorials/dnsimple.md Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

mloiseleur · 2024-03-15T17:30:59Z

provider/dnsimple/dnsimple.go

-	whoamiResponse, err := provider.identity.Whoami(context.Background())
-	if err != nil {
-		return nil, err
+	provider.accountID = dnsimpleAccountId


Suggested change

provider.accountID = dnsimpleAccountId

provider.accountID = os.Getenv("DNSIMPLE_ACCOUNT_ID")

Added in 487501d

mloiseleur · 2024-03-15T17:31:06Z

provider/dnsimple/dnsimple.go

 	oauthToken := os.Getenv("DNSIMPLE_OAUTH")
+	dnsimpleAccountId := os.Getenv("DNSIMPLE_ACCOUNT_ID")


Suggested change

dnsimpleAccountId := os.Getenv("DNSIMPLE_ACCOUNT_ID")

Added in 487501d

mloiseleur

See my last suggestion about dnsimpleAccountId + Wdyt about keeping only NewDnsimpleProvider func without adding BuildDnsimpleProvider ?

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor the BuildDnsimpleProvider method so that the dnsimpleAccountId variable, which was only used once, can be removed

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor so that the BuildDnsimpleProvider method can be removed and the NewDnsimpleProvider method be used exclusively instead

IntegralProgrammer · 2024-03-15T23:01:31Z

See my last suggestion about dnsimpleAccountId + Wdyt about keeping only NewDnsimpleProvider func without adding BuildDnsimpleProvider ?

I've removed the need for the dnsimpleAccountId variable in commit 487501d and have refactored the code in dnsimple_test.go using a type assertion so that BuildDnsimpleProvider is no longer needed - ed3efdb

mloiseleur · 2024-03-16T07:43:42Z

/lgtm

szuecs · 2024-04-25T14:52:15Z

/approve

k8s-ci-robot · 2024-04-25T14:52:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…rnal-dns to v0.14.2@3fcad62 by renovate (#22163) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | patch | `v0.14.1` -> `v0.14.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.14.2`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.14.2) [Compare Source](https://github.com/kubernetes-sigs/external-dns/compare/v0.14.1...v0.14.2) #### What's Changed - kustomize-v0.14.1 by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4331 - replace all links in tutorials for v0.14.1 by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4332 - chore: upgrade ExternalDNS to go 1.22 by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4318 - build(deps): bump the dev-dependencies group with 13 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4329 - build(deps): bump the dev-dependencies group with 5 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4334 - build(deps): bump the dev-dependencies group with 9 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4349 - build(deps): bump the dev-dependencies group with 1 update by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4341 - Add `dnsendpoint` CRD to Helm chart by [@onedr0p](https://github.com/onedr0p) in [kubernetes-sigs/external-dns#4322 - build(deps): bump the dev-dependencies group with 13 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4361 - build(deps): bump GrantBirki/json-yaml-validate from 2.6.1 to 2.6.2 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4364 - chore(chart): Released chart for v0.14.1 by [@stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4357 - chore: alphabetical order on providers by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4350 - doc: advertise current plan on providers by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4365 - Fix(ipv6): support ipv6 shortener and expander equal by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4351 - feat(WebhookProvider): Let WebhookProvider return `SoftError` on response status codes >= 500 by [@SimonKienzler](https://github.com/SimonKienzler) in [kubernetes-sigs/external-dns#4319 - Webhook provider: Use correct error gauge in `AdjustEndpoints()` func by [@SimonKienzler](https://github.com/SimonKienzler) in [kubernetes-sigs/external-dns#4374 - build(deps): bump the dev-dependencies group with 18 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4381 - Add exclude domains value in Chart by [@bford-evs](https://github.com/bford-evs) in [kubernetes-sigs/external-dns#4380 - docs(aws): fix typo and upgrade cleanup flow by [@franzudev](https://github.com/franzudev) in [kubernetes-sigs/external-dns#4389 - docs(gke): detail how to configure workload identity by [@userbradley](https://github.com/userbradley) in [kubernetes-sigs/external-dns#4373 - chore(ci): fix failing test by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4397 - chore: Update controller-tools version to v0.14.0 by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4400 - chore(ci): update golangci-lint to v1.57.2 by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4406 - chore: upgrade ExternalDNS to go 1.22.2 by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4414 - build(deps): bump the dev-dependencies group across 1 directory with 4 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4412 - build(deps): bump the dev-dependencies group across 1 directory with 24 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4416 - custom Azure Active Directory Authority Host by [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) in [kubernetes-sigs/external-dns#4210 - feat(DNSimple): User API tokens by [@IntegralProgrammer](https://github.com/IntegralProgrammer) in [kubernetes-sigs/external-dns#4274 - docs: annotation placement for azuredns tutorial by [@jonas-budde](https://github.com/jonas-budde) in [kubernetes-sigs/external-dns#4415 - feat(azure): add zone name filter for Azure Private DNS by [@khuedoan](https://github.com/khuedoan) in [kubernetes-sigs/external-dns#4346 - test: detect no change necessary with provider specific config by [@szuecs](https://github.com/szuecs) in [kubernetes-sigs/external-dns#4189 - docs: add setup example with helm chart on some providers by [@omerap12](https://github.com/omerap12) in [kubernetes-sigs/external-dns#4405 - test: controller run() and successfully shutdown by [@szuecs](https://github.com/szuecs) in [kubernetes-sigs/external-dns#3639 - fix syntax on cloudflare externalDNS by [@ilyesAj](https://github.com/ilyesAj) in [kubernetes-sigs/external-dns#4436 - build(deps): bump the dev-dependencies group across 1 directory with 11 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4440 - chore(chart): Adding extra containers by [@omerap12](https://github.com/omerap12) in [kubernetes-sigs/external-dns#4432 - aws: add ca-west-1 region by [@jeremy-albuixech](https://github.com/jeremy-albuixech) in [kubernetes-sigs/external-dns#4444 - fix: duplicated endpoint per hosted zone by [@leonardocaylent](https://github.com/leonardocaylent) in [kubernetes-sigs/external-dns#4296 - build(deps): bump actions/checkout from 4.1.4 to 4.1.5 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4438 - Add IPv6 AAAA record support to PiHole provider by [@PseudoResonance](https://github.com/PseudoResonance) in [kubernetes-sigs/external-dns#4324 - fix: soft error on cloudflare rate limits by [@ebachle](https://github.com/ebachle) in [kubernetes-sigs/external-dns#4437 - Update cloudflare.md by [@mfreeman451](https://github.com/mfreeman451) in [kubernetes-sigs/external-dns#4449 - Fix headings, whitespace by [@stefanlasiewski](https://github.com/stefanlasiewski) in [kubernetes-sigs/external-dns#4457 - docs: add reference to anexia webhook provider by [@ProbstenHias](https://github.com/ProbstenHias) in [kubernetes-sigs/external-dns#4441 - fix logline mentioning plugin api by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4459 - docs: lint gke docs + make terraform config more secure by [@DrFaust92](https://github.com/DrFaust92) in [kubernetes-sigs/external-dns#4456 - build(deps): bump action-stars/install-tool-from-github-release from 0.2.2 to 0.2.3 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4464 - changed documentation to include more details description when using API Tokens by [@rhjensen79](https://github.com/rhjensen79) in [kubernetes-sigs/external-dns#4474 - fix: add clarification to endpoint unit tests by [@leonardocaylent](https://github.com/leonardocaylent) in [kubernetes-sigs/external-dns#4462 - build(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4476 - build(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4475 #### New Contributors - [@onedr0p](https://github.com/onedr0p) made their first contribution in [kubernetes-sigs/external-dns#4322 - [@SimonKienzler](https://github.com/SimonKienzler) made their first contribution in [kubernetes-sigs/external-dns#4319 - [@bford-evs](https://github.com/bford-evs) made their first contribution in [kubernetes-sigs/external-dns#4380 - [@franzudev](https://github.com/franzudev) made their first contribution in [kubernetes-sigs/external-dns#4389 - [@userbradley](https://github.com/userbradley) made their first contribution in [kubernetes-sigs/external-dns#4373 - [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) made their first contribution in [kubernetes-sigs/external-dns#4210 - [@IntegralProgrammer](https://github.com/IntegralProgrammer) made their first contribution in [kubernetes-sigs/external-dns#4274 - [@jonas-budde](https://github.com/jonas-budde) made their first contribution in [kubernetes-sigs/external-dns#4415 - [@khuedoan](https://github.com/khuedoan) made their first contribution in [kubernetes-sigs/external-dns#4346 - [@omerap12](https://github.com/omerap12) made their first contribution in [kubernetes-sigs/external-dns#4405 - [@ilyesAj](https://github.com/ilyesAj) made their first contribution in [kubernetes-sigs/external-dns#4436 - [@jeremy-albuixech](https://github.com/jeremy-albuixech) made their first contribution in [kubernetes-sigs/external-dns#4444 - [@leonardocaylent](https://github.com/leonardocaylent) made their first contribution in [kubernetes-sigs/external-dns#4296 - [@PseudoResonance](https://github.com/PseudoResonance) made their first contribution in [kubernetes-sigs/external-dns#4324 - [@ebachle](https://github.com/ebachle) made their first contribution in [kubernetes-sigs/external-dns#4437 - [@mfreeman451](https://github.com/mfreeman451) made their first contribution in [kubernetes-sigs/external-dns#4449 - [@ProbstenHias](https://github.com/ProbstenHias) made their first contribution in [kubernetes-sigs/external-dns#4441 - [@DrFaust92](https://github.com/DrFaust92) made their first contribution in [kubernetes-sigs/external-dns#4456 - [@rhjensen79](https://github.com/rhjensen79) made their first contribution in [kubernetes-sigs/external-dns#4474 **Full Changelog**: kubernetes-sigs/external-dns@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Allow for DNSimple User API tokens to be used by implementing the DNS…

9b3c285

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables

k8s-ci-robot requested review from johngmyers and szuecs February 21, 2024 20:32

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 21, 2024

IntegralProgrammer mentioned this pull request Feb 21, 2024

Allow for User API tokens to be used with DNSimple #4273

Closed

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2024

IntegralProgrammer added 6 commits February 26, 2024 10:48

Allow for DNSimple User API tokens to be used by implementing the DNS…

ea2d259

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update documentation for these new environment variables

Allow for DNSimple User API tokens to be used by implementing the DNS…

26694e4

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update tests to check that the Zones function returns the correct DNS zones when the DNSIMPLE_ZONES environment variable is set

Allow for DNSimple User API tokens to be used by implementing the DNS…

d0c121b

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Update tests to check that the dnsimpleSuitableZone function works properly when the DNSIMPLE_ZONES environment variable is set

Allow for DNSimple User API tokens to be used by implementing the DNS…

d475eb6

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Small refactoring to NewDnsimpleProvider function to improve its testability

Fix provider/dnsimple/dnsimple_test.go: Add the missing call to NewDn…

3babcbc

…simpleProvider for testing its behavior when the DNSIMPLE_OAUTH environment variable is not set

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2024

IntegralProgrammer commented Feb 26, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2024

k8s-ci-robot changed the title ~~Allow for User API tokens to be used with DNSimple~~ feat(DNSimple): User API tokens Mar 12, 2024

IntegralProgrammer added 2 commits March 14, 2024 20:23

Allow for DNSimple User API tokens to be used by implementing the DNS…

eb59b9b

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Fix code linting error - use !skipWhoami instead of skipWhoami == false

Allow for DNSimple User API tokens to be used by implementing the DNS…

c54a9a8

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Fix code linting error - remove () from ZonesFromZoneString which only returns one value

mloiseleur reviewed Mar 15, 2024

View reviewed changes

docs/tutorials/dnsimple.md Outdated Show resolved Hide resolved

mloiseleur reviewed Mar 15, 2024

View reviewed changes

IntegralProgrammer and others added 3 commits March 15, 2024 11:07

Allow for DNSimple User API tokens to be used by implementing the DNS…

9c24ecc

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor the BuildDnsimpleProvider method so that it no longer needs the skipWhoami bool parameter

Allow for DNSimple User API tokens to be used by implementing the DNS…

660b20b

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor the BuildDnsimpleProvider method so that it no longer needs the skipWhoami bool parameter

Allow for DNSimple User API tokens to be used by implementing the DNS…

3eb852f

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Grammar fix in docs/tutorials/dnsimple.md Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

mloiseleur reviewed Mar 15, 2024

View reviewed changes

IntegralProgrammer added 2 commits March 15, 2024 18:45

Allow for DNSimple User API tokens to be used by implementing the DNS…

487501d

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor the BuildDnsimpleProvider method so that the dnsimpleAccountId variable, which was only used once, can be removed

Allow for DNSimple User API tokens to be used by implementing the DNS…

ed3efdb

…IMPLE_ACCOUNT_ID and DNSIMPLE_ZONES environment variables Refactor so that the BuildDnsimpleProvider method can be removed and the NewDnsimpleProvider method be used exclusively instead

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2024

k8s-ci-robot assigned mloiseleur Mar 16, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024

k8s-ci-robot merged commit aee99e2 into kubernetes-sigs:master Apr 25, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(DNSimple): User API tokens #4274

feat(DNSimple): User API tokens #4274

IntegralProgrammer commented Feb 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 21, 2024 •

edited

Loading

k8s-ci-robot commented Feb 21, 2024

k8s-ci-robot commented Feb 21, 2024

szuecs commented Feb 23, 2024

IntegralProgrammer Feb 26, 2024

IntegralProgrammer commented Feb 26, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 12, 2024

mloiseleur commented Mar 12, 2024

mloiseleur Mar 15, 2024

IntegralProgrammer Mar 15, 2024

mloiseleur Mar 15, 2024

IntegralProgrammer Mar 15, 2024

mloiseleur Mar 15, 2024

IntegralProgrammer Mar 15, 2024

mloiseleur left a comment

IntegralProgrammer commented Mar 15, 2024

mloiseleur commented Mar 16, 2024

szuecs commented Apr 25, 2024

k8s-ci-robot commented Apr 25, 2024

		os.Unsetenv("DNSIMPLE_OAUTH")
		_, err = NewDnsimpleProvider(endpoint.NewDomainFilter([]string{"example.com"}), provider.NewZoneIDFilter([]string{""}), true)

	provider.accountID = dnsimpleAccountId
	provider.accountID = os.Getenv("DNSIMPLE_ACCOUNT_ID")

		oauthToken := os.Getenv("DNSIMPLE_OAUTH")
		dnsimpleAccountId := os.Getenv("DNSIMPLE_ACCOUNT_ID")

feat(DNSimple): User API tokens #4274

feat(DNSimple): User API tokens #4274

Conversation

IntegralProgrammer commented Feb 21, 2024 • edited Loading

linux-foundation-easycla bot commented Feb 21, 2024 • edited Loading

k8s-ci-robot commented Feb 21, 2024

k8s-ci-robot commented Feb 21, 2024

szuecs commented Feb 23, 2024

IntegralProgrammer Feb 26, 2024

Choose a reason for hiding this comment

IntegralProgrammer commented Feb 26, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 12, 2024

mloiseleur commented Mar 12, 2024

mloiseleur Mar 15, 2024

Choose a reason for hiding this comment

IntegralProgrammer Mar 15, 2024

Choose a reason for hiding this comment

mloiseleur Mar 15, 2024

Choose a reason for hiding this comment

IntegralProgrammer Mar 15, 2024

Choose a reason for hiding this comment

mloiseleur Mar 15, 2024

Choose a reason for hiding this comment

IntegralProgrammer Mar 15, 2024

Choose a reason for hiding this comment

mloiseleur left a comment

Choose a reason for hiding this comment

IntegralProgrammer commented Mar 15, 2024

mloiseleur commented Mar 16, 2024

szuecs commented Apr 25, 2024

k8s-ci-robot commented Apr 25, 2024

IntegralProgrammer commented Feb 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 21, 2024 •

edited

Loading