-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headless service: retrieve endpoints via Endpoints resource; evaluate spec.publishNotReadyAddresses #1005
Conversation
/assign @Raffo |
Note: this will change the default behaviour. Before, the IPs of all |
2b14f6f
to
94fa80f
Compare
@Raffo @njuettner any chance to get this reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devkid I added one minor comment and I have two requests:
- Add a comment to the function
extractHeadlessEndpoints
to specify what it does. I know there was no comment before but this was IMO bad and we now have a chance to fix it, especially with the changed behaviour. - Write a little sentence that we can add to future release notes on how the behaviour has changed.
Additionally, I'm thinking wether we should add a flag to enable/disable the changed behaviour. I think we could add it and keep it around for a few releases before getting rid of it. WDYT? /cc @linki @njuettner
623b15c
to
9e43d65
Compare
@Raffo added an option to restore the old behavior via CLI flag and added a comment for |
9e43d65
to
6546c9e
Compare
Failing test is fixed now. Description for release:
|
Any update on this? |
1535588
to
36f7984
Compare
Conflict resolved, documentation with inline RBAC permissions updated. I will create a pull request in https://github.com/helm/charts to up the version and add the endpoints resources permissions when there is a new release. |
When is this targeted? |
23dfd7b
to
8882900
Compare
Any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments, PTAL.
… spec.publishNotReadyAddresses Currently, the endpoints of headless services are retrieved by querying pods using the pod selector of the service. Instead, we now query for an Endpoints resource with the same name as the Service object to get the endpoints for the service. This is needed in order to support the spec.publishNotReadyPods attribute of a service.
0860c23
to
85bf10a
Compare
85bf10a
to
65208db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devkid, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Version bumped to 2.20.4 Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Version bumped to 2.20.4 Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
Currently, the endpoints of headless services are retrieved
by querying pods using the pod selector of the service.
Instead, we now query for an Endpoints resource with the
same name as the Service object to get the endpoints for the
service. This is needed in order to support the
spec.publishNotReadyPods attribute of a service.
endpoints
resources