Fix panic on empty targets for custom resources. #1029
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Hi @arturo-c , thanks for your contribution. While your fix will definitely fix the panic, I'm not sure it would be the best change. Does it make sense to even allow an empty list of target? We should probably rather add validation to make sure that this can't happen at all. |
k8s-ci-robot
added
size/M
|
@Raffo Added some checks for crd validation, let me know if thats what you were thinking |
source/crd.go
Outdated
| @@ -117,7 +117,14 @@ func (cs *crdSource) Endpoints() ([]*endpoint.Endpoint, error) { | |||
| } | |||
|
|
|||
| for _, dnsEndpoint := range result.Items { | |||
| endpoints = append(endpoints, dnsEndpoint.Spec.Endpoints...) | |||
| // Make sure that all endpoints have targets for A or CNAME type | |||
| for _, endPoint := range dnsEndpoint.Spec.Endpoints { | |||
There was a problem hiding this comment.
Nit: please use endpoint instead of endPoint
There was a problem hiding this comment.
done, thanks for catching
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixes #1027