-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update digitalocean/godo to the latest stable version #1145
Conversation
aa9b287
to
84617a4
Compare
/assign @Raffo The build failure seems to be related to a Requesting your review on this :). |
@tariq1890 did you test this with a real cluster? I don't have infra to do so, but the PR looks good! |
@Raffo Neither do I. We use the What can we do to address this? |
Howdy! I'm an engineer with DigitalOcean's Kubernetes team. The PR looks good to me. I've verified it works properly on a DOKS cluster as well. |
@jcodybaker btw, we (as External DNS maintainers) would also welcome any support/maintainers for Digital Ocean in External DNS --- e.g. test infra, maintainers for the DO code path etc. |
/lgtm |
Can this be merged? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjacobs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @hjacobs I don't have too much hands-on experience with external-dns yet, but I'd be happy to provide support and / or ownership for the DigitalOcean part nevertheless. The scope of the project seems reasonably sized for someone new to be able to become familiar with. Feel free to ping me liberally on any DO matters (feature requests, but reports, triaging, etc.) and / or mark me as an owner for the relevant area per your discretion and the project's structure. I'm also on the Kubernetes Slack for further discussions. Thanks! |
This PR is needed as the
godo
version is archaic.It also fixes problematic deps like
i) importing of digitalocean's custom context lib which has been since phased out.
ii) transitive import of
launchpad.net/gocheck
which is not hosted in agit
repo.