Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update digitalocean/godo to the latest stable version #1145

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

tariq1890
Copy link
Contributor

This PR is needed as the godo version is archaic.

It also fixes problematic deps like

i) importing of digitalocean's custom context lib which has been since phased out.
ii) transitive import of launchpad.net/gocheck which is not hosted in a git repo.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2019
@tariq1890 tariq1890 force-pushed the upd_godo branch 2 times, most recently from aa9b287 to 84617a4 Compare August 13, 2019 23:58
@tariq1890
Copy link
Contributor Author

/assign @Raffo

The build failure seems to be related to a coveralls problem.

Requesting your review on this :).

@Raffo
Copy link
Contributor

Raffo commented Aug 14, 2019

@tariq1890 did you test this with a real cluster? I don't have infra to do so, but the PR looks good!

@tariq1890
Copy link
Contributor Author

@Raffo Neither do I. We use the external-dns as a dependency and its transitive deps through godo impacts us.

What can we do to address this?

@jcodybaker
Copy link

Howdy! I'm an engineer with DigitalOcean's Kubernetes team. The PR looks good to me. I've verified it works properly on a DOKS cluster as well.

@hjacobs
Copy link
Contributor

hjacobs commented Aug 15, 2019

@jcodybaker btw, we (as External DNS maintainers) would also welcome any support/maintainers for Digital Ocean in External DNS --- e.g. test infra, maintainers for the DO code path etc.

@hjacobs
Copy link
Contributor

hjacobs commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@tariq1890
Copy link
Contributor Author

Can this be merged?

@hjacobs
Copy link
Contributor

hjacobs commented Aug 15, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjacobs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1cc4867 into kubernetes-sigs:master Aug 15, 2019
@tariq1890 tariq1890 deleted the upd_godo branch August 15, 2019 16:36
@timoreimann
Copy link

Hey @hjacobs

I don't have too much hands-on experience with external-dns yet, but I'd be happy to provide support and / or ownership for the DigitalOcean part nevertheless. The scope of the project seems reasonably sized for someone new to be able to become familiar with.

Feel free to ping me liberally on any DO matters (feature requests, but reports, triaging, etc.) and / or mark me as an owner for the relevant area per your discretion and the project's structure.

I'm also on the Kubernetes Slack for further discussions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants