-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for human-friendly TTL values #1237
Conversation
Welcome @hypnoglow! |
89f7c88
to
3a4d84b
Compare
/assign @Raffo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍. I added two comments, PTAL.
3a4d84b
to
3850c16
Compare
3850c16
to
4569026
Compare
Rebased as it was a bit stale |
@hypnoglow Can you please check linting again
|
4569026
to
6e6af8a
Compare
Supports specifying TTL values in Golang duration format for `external-dns.alpha.kubernetes.io/ttl` annotation.
@njuettner Should be fixed now, thanks for the remark. |
@hypnoglow sorry for my late response, what happens when people still use the old annotation, will this break things when releasing this PR in the next release? I want to avoid this TBH. |
Old behaviour is preserved, annotations with integer values representing seconds should still work, tests still cover it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hypnoglow, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for specifying TTL values in Golang duration format for
external-dns.alpha.kubernetes.io/ttl
annotation.Fixes #1183