-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked tutorial for Azure Private DNS #1319
Reworked tutorial for Azure Private DNS #1319
Conversation
FYI @timja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I don’t remember having to do this but I tested it on minikube, it’s probably on by default there.
I’ve had to enable this when using traefik before
This looks good to me as well. Sorry for the slow response and thanks for doing the update. This is mentioned in the tutorial but I wanted to point out explicitly that when controller.publishService.enabled=true is set on the ingress controller a describe of the ingress resource will show the IP of the load balancer in the address column as shown below. This does not happen (field is blank) is that parameter is not set.
|
Would you recommend...
I tend to go for 2). |
Agree that #2 is best. |
493935c
to
c665761
Compare
Thanks Dave. Updated the doc accordingly. |
Also thanks @timja for checking this out. I remove WIP now. |
/assign @njuettner Would you help again by reviewing and merging? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saidst I just have one trivial suggestion, the other parts are good to go. Ping me once you fixed that and we can merge it.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, saidst The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First use showed the tutorial for Azure DNS & Azure Private DNS to be not practically usable for all users.
In particular, it required some special knowledge about the required configuration of the employeed nginx-ingress-controller.
This PR refines the tutorial to make endusers be able to work through it completely.