add ctx parameter to provider interface and aws API #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @njuettner |
njuettner
approved these changes
Jan 13, 2020
|
lgtm. Let's wait until we get the current release out before merging this. |
k8s-ci-robot
added
the
do-not-merge/hold
This is a private project. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@tariq1890 Thank you! |
|
/remove hold |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a breaking change.
Why am I doing this?
i) We use external-dns as a dependency and we are forced to use a private fork since we need to use AWS API calls with context. We'd really like to stop using the fork and have these changes passed upstream.
ii) I think this breaking change is justified since passing contexts down an API call stack is considered a good pattern. This change should also pave way for removing the many
context.TODO()s in the codebase. This itself is proof that we ought to be passing contexts.Would to get your thoughts and review on this. Thanks!