-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement annotation filter for CRD source #1399
Implement annotation filter for CRD source #1399
Conversation
* Distinguish between local and edge dns types * Use custom external-dns build until upstream accept the kubernetes-sigs/external-dns#1399
* Debug and make helpers * Initial Edge DNS support * Dedicated DNSEndpoint to manage A records for NS servers pointing to GSLB * Initial Infoblox support * Annotation filtering for DNSEndpoints * Distinguish between local and edge dns types * Use custom external-dns build until upstream accept the kubernetes-sigs/external-dns#1399 * Bump version * sslVerify control for external-dns infoblox deployment
@hjacobs , @njuettner guys, any feedback ? |
@hjacobs , @njuettner the change is non-intrusive, covered by tests and tested out in real environment. Any chance we can merge it in soon? |
@hjacobs , @njuettner any update ? |
0856746
to
3998a37
Compare
Hi @Raffo , could you please look into this one ? Is anything blocking the merge ? Thanks in advance. |
I'm gonna try to work on the backlog on the weekend. Unfortunately those times aren't exactly normal, so my availability isn't great (not that it was before 😄). |
@Raffo that would be amazing, thanks :) |
@ytsarev It looks like tests are broken, can you take a look? |
* Ability to use `--annotation-filter` for CRD source * Use case is similar to https://github.com/kubernetes-sigs/external-dns/blob/master/docs/faq.md#running-an-internal-and-external-dns-service but for CRD source, effectively DNSEndpoints instead of Ingresses
3998a37
to
d432625
Compare
/retest |
@ytsarev: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @linki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, ytsarev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--annotation-filter
for CRD sourcebut for CRD source, effectively DNSEndpoints instead of Ingresses