-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use ClusterIP with internal-hostname annotation #1425
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @btoonk! |
9073d80
to
b1544ac
Compare
/assign @njuettner |
b1544ac
to
4f892b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't know if this is really needed but don't have any opinions for having it. Please also add docs, how to use the annotation, we have docs directory for that.
4f892b6
to
3c8b362
Compare
Hi @njuettner can we proceed with this pr ? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/kind feature |
@btoonk thank you for the PR! It looks like it needs to be rebased and there is a merge conflict with the FAQ page, could you please clean those up and we will try to get this reviewed as soon as possible? Thanks! |
ce476eb
to
ce4c1dc
Compare
@vinny-sabatini the merge conflict is resolved, I think this PR is ready for review now. |
56e7504
to
3813824
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: btoonk, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1213