Feature routegroup #1444
Merged
Feature routegroup #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@njuettner I fixed all your comments |
szuecs
force-pushed
the
feature/route-group
branch
2 times, most recently
from
f40460b
to
e70c5c0
Compare
|
@njuettner @linki I rebased and forced push to have a clean history. I also fixed a bug in the http.Client usage, I had before, which I found while testing in a dev cluster. |
add documentation for kube-ingress-aws-controller and RouteGroup Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs
force-pushed
the
feature/route-group
branch
from
e70c5c0
to
116856f
Compare
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
linki
reviewed
Mar 9, 2020
|
|
||
| token, err := ioutil.ReadFile(cli.tokenFile) | ||
| if err != nil { | ||
| log.Errorf("Failed to read token from file (%s): %v", cli.tokenFile, err) |
There was a problem hiding this comment.
Should we return here? This would retain the previous token if we failed to read the file.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linki, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1403
It does not use client-go, nor informer. It's just a simple poll on
Endpoints().I added also a tutorial for kube-ingress-aws-controller, that was missing and added there a RouteGroup part.
The
routegroupsource has the same feature set as theingresssource and needs to be enabled by--source=skipper-routegroup.In case you are interested, you can find a more detailed explanation of the RouteGroup CRD.