-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for openshift routes #1484
Support for openshift routes #1484
Conversation
/assign @Raffo |
@vinny-sabatini and @sanbornick please review if you have some time. |
@seanmalloy Thanks for the feedback. |
@jgrumboe let me know if you need any help making the changes. I can try to help. |
I gave the PR a read through (beginner with Go and not super knowledgeable on this repo) but it looks good to me |
/lgtm @Raffo this PR is ready for you to review/merge now. |
@seanmalloy @Raffo |
Any news? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjacobs, jgrumboe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Support for openshift routes
This implements a new source type "openshift-route" and adds support for openshift routes #706
I've taken the mentioned ocproute implementation from https://github.com/KohlsTechnology/external-dns/blob/timcurless-feature/source/ocproute.go and rebased it to master.
Tested against OpenShift 3.11 and Infoblox as provider.