Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update etcd dependency to latest version #1485

Merged
merged 1 commit into from
Apr 7, 2020
Merged

update etcd dependency to latest version #1485

merged 1 commit into from
Apr 7, 2020

Conversation

tariq1890
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2020
tariq1890
tariq1890 commented Apr 3, 2020
View reviewed changes
go.mod
@@ -49,6 +48,7 @@ require (
github.com/stretchr/testify v1.4.0
github.com/transip/gotransip v5.8.2+incompatible
github.com/vinyldns/go-vinyldns v0.0.0-20190611170422-7119fe55ed92
go.etcd.io/etcd v0.5.0-alpha.5.0.20200401174654-e694b7bb0875
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerned about this weird version number? Blame it on go modules :(.

go.etcd.io/etcd is using go.mod and go modules won't allow releases of v3.x unless it follows the semantic import versioning.

That version above still corresponds to the commit hash of v3.4.7, the release.

@tariq1890
Copy link
Contributor Author

/assign @njuettner

Requesting your review on this. I am making bite sized changes like these, so that I can eventually simplify the depedndency tree of external-dns and hopefully remove all of the replace hacks

njuettner
njuettner approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@njuettner
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 338367a into kubernetes-sigs:master Apr 7, 2020
@tariq1890 tariq1890 deleted the upd_etcd branch April 7, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@linki linki Awaiting requested review from linki

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tariq1890 @njuettner @k8s-ci-robot