Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RFC2316 Windows Documentation #1516

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix RFC2316 Windows Documentation #1516

merged 1 commit into from
Apr 23, 2020

Conversation

scottd018
Copy link
Contributor

Added documentation to show the use of the --rfc2136-insecure flag when integrating with Windows DNS when using insecure zone updates.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @scottd018!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2020
@njuettner
Copy link
Member

@scottd018 thanks, do you mind changing the commit message?

@scottd018
Copy link
Contributor Author

@scottd018 thanks, do you mind changing the commit message?

@njuettner Yep, I'm happy to fix it. One quick, ignorant question...what format do the commit messages need to be in? Apologies as this is my first time committing to this project. I looked through the contributing guidelines, and either I'm overlooking it, or I don't happen to see what the expected format is.

Let me know and I'll get it fixed for you right away. Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 17, 2020
@scottd018 scottd018 changed the title Fixes #1515, use --rfc2136 -insecure flag for windows dns Fix RFC2316 Windows Documentation Apr 17, 2020
@scottd018
Copy link
Contributor Author

@njuettner Give the new commit message a look. I am still having trouble finding what is proper. If it's wrong, I'll give it another try. Thanks.

@seanmalloy
Copy link
Member

/lgtm
/assign @njuettner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2020
njuettner
njuettner approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, scottd018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit fba0d49 into kubernetes-sigs:master Apr 23, 2020
@njuettner
Copy link
Member

@scottd018 thanks again for your PR and sorry for the late response. I saw you already figured it out 👍

@scottd018
Copy link
Contributor Author

@njuettner no problem! thanks for the merge and the patience with new contributors. :)

@seanmalloy seanmalloy mentioned this pull request Apr 27, 2020
Closed
aliasgharmhowwala pushed a commit to aliasgharmhowwala/external-dns that referenced this pull request Jun 15, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#1516 from scottd018/bugfix-windows…
ef81b69 
…-documentation-rfc2136

Fix RFC2316 Windows Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@linki linki Awaiting requested review from linki

Assignees

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scottd018 @k8s-ci-robot @njuettner @seanmalloy