Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme for latest version #1539

Merged
merged 1 commit into from
Apr 20, 2020
Merged

update readme for latest version #1539

merged 1 commit into from
Apr 20, 2020

Conversation

elsesiy
Copy link
Contributor

@elsesiy elsesiy commented Apr 19, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @elsesiy!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2020
@elsesiy
Copy link
Contributor Author

elsesiy commented Apr 19, 2020

/assign @njuettner

@hjacobs
Copy link
Contributor

hjacobs commented Apr 20, 2020

/lgtm

@hjacobs
Copy link
Contributor

hjacobs commented Apr 20, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsesiy, hjacobs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f4ac68 into kubernetes-sigs:master Apr 20, 2020
@elsesiy elsesiy deleted the fix/readme branch April 20, 2020 20:17
aliasgharmhowwala pushed a commit to aliasgharmhowwala/external-dns that referenced this pull request Jun 15, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#1539 from elsesiy/fix/readme
8abc09e 
update readme for latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@hjacobs hjacobs

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elsesiy @k8s-ci-robot @hjacobs @njuettner