Update go versions to 1.14.x that were missed in commit 99cebfcf from PR #1476

[stealthybox]

I found these out-of-date go versions when looking for the most recent external-dns binary version built with go1.14.1+.
This is because go binaries on certain Linux kernels can crash when built with go1.14 golang/go#37807.

The official release docker images seem to have either been built with Dockerfile.mini or via .travisci.yaml.
They both report being built with go1.13.x:

docker run --rm --entrypoint sh us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.0 -c 'grep -o "go1\....." "$(which external-dns)"'
go1.13.8

docker run --rm --entrypoint sh us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.1 -c 'grep -o "go1\....." "$(which external-dns)"'
go1.13.9

I happened to be using bitnami's docker images.
They do their own builds of the external-dns binary.
Their v0.7.0 build used go1.14 which was crashing for me.
Their v0.7.1 build used go1.14.1 which has the non-lethal behavior for patched kernels such as my Ubuntu 19.10 machine:

docker run --rm --entrypoint sh bitnami/external-dns:0.7.1-debian-10-r41 -c 'cat "$(which external-dns)" | grep -ao "go1\....."' | head -n1
go1.14.1

docker run --rm --entrypoint sh bitnami/external-dns:0.7.0-debian-10-r0 -c 'cat "$(which external-dns)" | grep -ao "go1\....."' | head -n1
go1.14go

After merging this patch, the next external-dns release (currently v0.7.2) will have official release images built with the latest version of go1.14.x

We should really be careful when bumping go versions.
We need to make sure we do it in all locations.
There are currently 4 places where this needs to be changed.

We could modify the builds to source GO_VERSION from the same location or write a test to verify the versions match across the builds.

/cc @linki @Raffo @jochen42
Related #1476

[k8s-ci-robot]

@stealthybox: GitHub didn't allow me to request PR reviews from the following users: jochen42.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I found these out-of-date go versions when looking for the most recent external-dns binary version built with go1.14.1+.
This is because go binaries on certain Linux kernels can crash when built with go1.14 golang/go#37807.

The official release docker images seem to have either been built with Dockerfile.mini or via .travisci.yaml.
They both report being built with go1.13.x:

docker run --rm --entrypoint sh us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.0 -c 'grep -o "go1\....." "$(which external-dns)"'
go1.13.8

docker run --rm --entrypoint sh us.gcr.io/k8s-artifacts-prod/external-dns/external-dns:v0.7.1 -c 'grep -o "go1\....." "$(which external-dns)"'
go1.13.9

I happened to be using bitnami's docker images.
They do their own builds of the external-dns binary.
Their v0.7.0 build used go1.14 which was crashing for me.
Their v0.7.1 build used go1.14.1 which has the non-lethal behavior for patched kernels such as my Ubuntu 19.10 machine:

docker run --rm --entrypoint sh bitnami/external-dns:0.7.1-debian-10-r41 -c 'cat "$(which external-dns)" | grep -ao "go1\....."' | head -n1
go1.14.1

docker run --rm --entrypoint sh bitnami/external-dns:0.7.0-debian-10-r0 -c 'cat "$(which external-dns)" | grep -ao "go1\....."' | head -n1
go1.14go

After merging this patch, the next external-dns release (currently v0.7.2) will have official release images built with the latest version of go1.14.x

We should really be careful when bumping go versions.
We need to make sure we do it in all locations.
There are currently 4 places where this needs to be changed.

We could modify the builds to source GO_VERSION from the same location or write a test to verify the versions match across the builds.

/cc @linki @Raffo @jochen42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[miry]

@stealthybox Would it make sense to keep both golang versions for testing?

[stealthybox]

This is already merged, but I don't believe it would make sense to matrix test go versions.
The releases are only published with one specific version of go.

Thanks for reading!

[hjacobs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjacobs, stealthybox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hjacobs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hjacobs]

/lgtm