-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent headless service name in example #1559
Conversation
Fix a typo and update the headless service name to be consistent.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @lowkeyliesmyth! |
Signed the CLA |
@lowkeyliesmyth can you fix one more case (at least I found) with same typo in tutorial: https://github.com/kubernetes-sigs/external-dns/blame/master/docs/tutorials/hostport.md#L84 |
@miry Thank you for pointing that out. I took care of the other "exeternal" typo instances, and after a cursory glance didn't find any others. |
/assign @njuettner |
@miry It looks like merging is blocked by a lack of "lgtm" or "mergeable" labels and I'm not sure who should provide either of those. |
@njuettner @hjacobs can you check pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowkeyliesmyth, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix a typo and update the headless service name to be consistent.