-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduling of reconciliation #1567
Conversation
/assign @Raffo |
b505853
to
d82a093
Compare
I think this is ready to be reviewed and merged |
26bff8e
to
533281f
Compare
@tariq1890 Please refresh, I've rebased this on master |
Changes LGTM. deferring to @njuettner or @Raffo |
@tariq1890 @ytsarev For the future: you can use /lgtm to inform bot as well :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, sheerun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is improved version of #1543. It makes sure that:
AddEventHandler(handler func() error, stopChan <-chan struct{}, minInterval time.Duration)
toAddEventHandler(ctx context.Context, handler func())
#1568 Should be merged first