-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Contour IngressRoute deps #1569
update Contour IngressRoute deps #1569
Conversation
Welcome @stevesloka! |
@@ -79,4 +79,5 @@ replace ( | |||
k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20190817221809-bf4de9df677c | |||
k8s.io/client-go => k8s.io/client-go v0.0.0-20190817222206-ee6c071a42cf | |||
k8s.io/klog => github.com/mikkeloscar/knolog v0.0.0-20190326191552-80742771eb6b | |||
github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.7-0.20190821215049-f062b07a671a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove the replace
directives for the k8s deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not really required) If not possible, we can leave it as-is. I can address it in my PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the go-control-plane
one since Contour has a later version in it's go.mod than Istio. When compiling there was a diff issue and couldn't get resolved. I'm happy to remove, this was just to make everything build properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it! Makes sense :)
96a1aeb
to
3dded30
Compare
Thanks a lot @stevesloka :) cc'ing @njuettner and @Raffo |
Hi @stevesloka ! Friendly ping to fix the minor |
47227e8
to
1ea22a1
Compare
source/ingressroute_test.go
Outdated
"testing" | ||
|
||
contour "github.com/heptio/contour/apis/contour/v1beta1" | ||
fakeContour "github.com/heptio/contour/apis/generated/clientset/versioned/fake" | ||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be grouped with the other third party imports too
source/ingressroute.go
Outdated
@@ -19,45 +19,50 @@ package source | |||
import ( | |||
"bytes" | |||
"fmt" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1ea22a1
to
5545031
Compare
Signed-off-by: Steve Sloka <slokas@vmware.com>
5545031
to
5c565da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @Raffo |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, stevesloka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates #1366 by updating the Project Contour deps. This is just an initial pass to unblock anyone from updating dependencies in the project. Contour has open issues to enable
Status
information inHTTPProxy
so that we can expose this information better.Once we have that we can submit a follow-up PR to clean up this logic as well as add support for
HTTPProxy
.Signed-off-by: Steve Sloka slokas@vmware.com