Enable azure_private_dns to work with non "AzurePublicCloud" clouds

[daddonpa]

The PrivateZoneClient by default communicates to the AzurePublicCloud resource manager endpoint.

To make the azure_private_dns work with other clouds like

• AzureUSGovernmentCloud
• AzureChinaCloud
• AzureGermanCloud

it should use the endpoint specific to the selected cloud.

This change makes it behave like the NewAzureProvider from azure.go

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @daddonpa!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[daddonpa]

I signed it

[Raffo]

@daddonpa is there a way we can add a test or prove this behaviour?

[daddonpa]

Added test to verify that NewAzurePrivateDNSProvider will use the ResourceManagerEndpoint of the configured cloud.

I am not sure if my way of testing (setting environment variable and casting an interface to the type I know it should be) is fine for go in general and this repository in particular but I could not find a better way to do it.

The same test can be added for NewAzureProvider where the behaviour is already implemented.

[daddonpa]

@Raffo is there something else I should add?

[daddonpa]

/assign @njuettner

[seanmalloy]

/kind feature

[tariq1890]

/lgtm

[seanmalloy]

@daddonpa can you rebase your PR to pull in the latest changes from master? I see that the new GItHub action CI check did not run for this PR. Thanks!

[seanmalloy]

/hold

Needs a rebase before it can be merged.

[daddonpa]

@seanmalloy rebased commits onto master

[seanmalloy]

/hold cancel

@tariq1890 please review one more time now that the PR has been rebased. Thanks!

[tariq1890]

/lgtm

[njuettner]

Please add you PR to the CHANGELOG.md, we can merge it afterwards

[daddonpa]

@njuettner Added Pull Request to CHANGELOG.md

[seanmalloy]

/assign @Raffo @njuettner

[seanmalloy]

/lgtm

[Raffo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daddonpa, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment